chore(package): add ESLint #600

levithomason · 2018-12-11T22:37:07Z

This PR replaces ts-lint with eslint.

reduced linting time from >13s to ~3s 🎉
there is far more support and better plugins in the eslint community
we can now lint/fix JS files, which were getting ignored before by ts-lint

Changes

added ESLint with common plugins
disabled all failing rules, with uncomment them in future PRs

miroslavstastny · 2018-12-12T14:33:55Z

package.json

@@ -19,6 +19,8 @@
    "deploy:docs": "gulp deploy:docs",
    "lint": "tslint -t stylish -p .",


this is now broken

miroslavstastny · 2018-12-12T14:35:02Z

package.json

@@ -19,6 +19,8 @@
    "deploy:docs": "gulp deploy:docs",
    "lint": "tslint -t stylish -p .",
    "lint:fix": "yarn lint --fix",
+    "eslint": "eslint .",


I would prefer to name this just lint. The fact that we use eslint for that is an implementation detail I don't care about.

Just FYI, while the PR was in WIP state, I had both so I could run parallel tests of the two. Certainly agree on lint 👍

levithomason · 2019-01-11T19:50:06Z

This PR is blocked waiting on the latest release from eslint-typescript-parser. Our update to [email protected] is actually a breaking change for typescript-estree:

WARNING: You are currently running a version of TypeScript which is not officially
supported by typescript-estree.

SUPPORTED TYPESCRIPT VERSIONS: ~3.1.1
YOUR TYPESCRIPT VERSION: 3.2.2

See either of these issues:
eslint/typescript-eslint-parser#576
eslint/typescript-eslint-parser#589

layershifter · 2019-02-08T12:42:58Z

Updated dependencies and unblocked PR 👍

levithomason · 2019-02-27T23:50:33Z

I fixed the yarn.lock, but this caused issues with ESLint resolving the eslint config. Once fixing the resolution, there were over 3k lint errors. Will have to come back to this one.

…/stardust-ui/react into chore/unused-vars # Conflicts: # yarn.lock

…ore/unused-vars # Conflicts: # package.json # packages/react/package.json # types/screener.d.ts # yarn.lock

DustyTheBot · 2019-04-19T10:13:07Z

	Warnings
⚠️	There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.
⚠️	Package (or peer) dependencies changed. Make sure you have approval before merging!

Changed dependencies in packages/internal-tooling/package.json

package	before	after
@typescript-eslint/eslint-plugin	-	^1.6.0
@typescript-eslint/parser	-	^1.6.0
eslint	-	^5.16.0
eslint-config-airbnb	-	^17.1.0
eslint-config-prettier	-	^4.1.0
eslint-plugin-import	-	^2.17.2
eslint-plugin-jest	-	^22.4.1
eslint-plugin-jsx-a11y	-	^6.2.1
eslint-plugin-prettier	-	^3.0.1
eslint-plugin-react	-	^7.12.4
eslint-plugin-react-hooks	-	^1.6.0

Generated by 🚫 dangerJS

codecov · 2019-04-19T10:13:39Z

Codecov Report

Merging #600 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #600   +/-   ##
======================================
  Coverage    72.1%   72.1%           
======================================
  Files         731     731           
  Lines        5592    5592           
  Branches     1612    1612           
======================================
  Hits         4032    4032           
  Misses       1555    1555           
  Partials        5       5

Impacted Files	Coverage Δ
packages/react/src/lib/whatInput.ts	`65.47% <ø> (ø)`	⬆️
packages/react-proptypes/src/leven.ts	`100% <ø> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ba7100...e424023. Read the comment docs.

layershifter · 2019-04-19T10:15:09Z

.eslintrc.json

@@ -0,0 +1,4 @@
+{
+  "extends": ["./packages/internal-tooling/eslint/index.js"],


Paths are not great, should be fixed in ESLint 6: eslint/eslint#11388

layershifter · 2019-04-19T10:16:05Z

build/gulp/tasks/test-projects/.eslintrc.json

@@ -0,0 +1,5 @@
+{
+  "rules": {
+    "import/no-unresolved": "off"


We have requires for Enzyme, Simulant and other stuff that it's not in direct dependencies. Currently disabled

layershifter · 2019-04-19T10:17:14Z

packages/react/.eslintrc.json

+    {
+      "files": "**/icons/*.tsx",
+      "rules": {
+        "react/prop-types": "off"


ESLint with React plugin handles these icons as React components, it will be very strange to have there propTypes...

layershifter · 2019-04-19T10:17:57Z

packages/internal-tooling/eslint/index.js

+    {
+      files: '**/jest.config.js',
+      rules: {
+        'global-require': 'off',


It's safe to use require() there

layershifter · 2019-04-24T16:04:33Z

We decided to keep TSLint before at least important rules will work properly.

levithomason requested review from dvdzkwsk, kuzhelov, layershifter, miroslavstastny and mnajdova as code owners December 11, 2018 22:37

miroslavstastny reviewed Dec 12, 2018

View reviewed changes

kuzhelov added the needs author feedback Author's opinion is asked label Dec 12, 2018

layershifter mentioned this pull request Dec 13, 2018

feat(Dropdown): Single selection #584

Merged

layershifter mentioned this pull request Dec 18, 2018

docs(Examples): allow to use TS in examples #617

Merged

levithomason changed the title ~~chore: replace ts-lint with eslint~~ [WIP] chore: replace ts-lint with eslint Jan 11, 2019

levithomason added 🚧 WIP and removed needs author feedback Author's opinion is asked labels Jan 11, 2019

levithomason force-pushed the chore/unused-vars branch from 103e0ae to 7b2af65 Compare January 11, 2019 23:34

layershifter mentioned this pull request Feb 8, 2019

feat(dropdown): inline prop #863

Merged

chore: replace ts-lint with eslint

be899a8

layershifter force-pushed the chore/unused-vars branch from 7b2af65 to be899a8 Compare February 8, 2019 12:36

update dependencies, fix configs

46757bf

layershifter removed the 💥 blocked label Feb 8, 2019

levithomason mentioned this pull request Mar 6, 2019

Access modifiers and order of members in React components #936

Closed

layershifter added 6 commits March 12, 2019 12:02

Merge branches 'chore/unused-vars' and 'master' of https://github.com…

86d867e

…/stardust-ui/react into chore/unused-vars # Conflicts: # yarn.lock

wip!

df3a6fa

Merge branch 'master' of https://github.com/stardust-ui/react into ch…

405fb8a

…ore/unused-vars # Conflicts: # package.json # packages/react/package.json # types/screener.d.ts # yarn.lock

remove TSLint rule

7c426bf

revert changes in focusUtilities

52ae358

disable import rule for whole directory

ecb13b9

layershifter added 6 commits April 19, 2019 11:16

cleanup configs

030b615

revert change in test

202d843

more dependencies, rearrange configs, disable rules

445509f

disable more rules

08d567b

disable more rules

db0a956

disable more rules

d05daf9

layershifter added 🚀 ready for review and removed 🚧 WIP labels Apr 19, 2019

layershifter changed the title ~~[WIP] chore: replace ts-lint with eslint~~ chore(package): replace ts-lint with eslint Apr 19, 2019

layershifter reviewed Apr 19, 2019

View reviewed changes

miroslavstastny approved these changes Apr 24, 2019

View reviewed changes

layershifter and others added 4 commits April 24, 2019 18:34

restore TSLint

1916863

restore rules and configs

60db12d

fix eval issue

8ddba63

Merge branch 'master' into chore/unused-vars

e424023

layershifter changed the title ~~chore(package): replace ts-lint with eslint~~ chore(package): add ESLint Apr 24, 2019

layershifter merged commit e49e121 into master Apr 24, 2019

delete-merged-branch bot deleted the chore/unused-vars branch April 24, 2019 16:14

layershifter mentioned this pull request Apr 24, 2019

style(eslint): enable spaced-comment, @typescript-eslint/no-unused-vars #1261

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(package): add ESLint #600

chore(package): add ESLint #600

levithomason commented Dec 11, 2018 •

edited by layershifter

Loading

miroslavstastny Dec 12, 2018

miroslavstastny Dec 12, 2018

levithomason Jan 11, 2019

levithomason commented Jan 11, 2019

layershifter commented Feb 8, 2019

levithomason commented Feb 27, 2019

DustyTheBot commented Apr 19, 2019

codecov bot commented Apr 19, 2019 •

edited

Loading

layershifter Apr 19, 2019

layershifter Apr 19, 2019

layershifter Apr 19, 2019

layershifter Apr 19, 2019

layershifter commented Apr 24, 2019

		@@ -19,6 +19,8 @@
		"deploy:docs": "gulp deploy:docs",
		"lint": "tslint -t stylish -p .",

		@@ -0,0 +1,4 @@
		{
		"extends": ["./packages/internal-tooling/eslint/index.js"],

chore(package): add ESLint #600

chore(package): add ESLint #600

Conversation

levithomason commented Dec 11, 2018 • edited by layershifter Loading

Changes

miroslavstastny Dec 12, 2018

Choose a reason for hiding this comment

miroslavstastny Dec 12, 2018

Choose a reason for hiding this comment

levithomason Jan 11, 2019

Choose a reason for hiding this comment

levithomason commented Jan 11, 2019

layershifter commented Feb 8, 2019

levithomason commented Feb 27, 2019

DustyTheBot commented Apr 19, 2019

codecov bot commented Apr 19, 2019 • edited Loading

Codecov Report

layershifter Apr 19, 2019

Choose a reason for hiding this comment

layershifter Apr 19, 2019

Choose a reason for hiding this comment

layershifter Apr 19, 2019

Choose a reason for hiding this comment

layershifter Apr 19, 2019

Choose a reason for hiding this comment

layershifter commented Apr 24, 2019

levithomason commented Dec 11, 2018 •

edited by layershifter

Loading

codecov bot commented Apr 19, 2019 •

edited

Loading